From 8f9b6d66be171a655e372f964c730456e2abde74 Mon Sep 17 00:00:00 2001 From: Anish Bhobe Date: Wed, 2 Apr 2025 21:08:14 +0200 Subject: [PATCH] At par with old-arch. FIXED: Bug with black speckles in prefilter. Caused by MipMapping enabled. --- samples/03_model_render/ibl_helpers.cpp | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/samples/03_model_render/ibl_helpers.cpp b/samples/03_model_render/ibl_helpers.cpp index e484531..89399d3 100644 --- a/samples/03_model_render/ibl_helpers.cpp +++ b/samples/03_model_render/ibl_helpers.cpp @@ -80,12 +80,14 @@ CreateCubeFromHdrEnv(AssetLoader *assetLoader, vk::Queue computeQueue, const u32 prefilterStorageHandles.push_back(commitManager->CommitStorageImage(view)); } - auto brdfLut = resourceManager->CombinedImageViews().CreateTexture2D({.m_Format = vk::Format::eR16G16Sfloat, - .m_Extent = {512, 512}, - .m_Name = "BRDF LUT", - .m_IsSampled = true, - .m_IsMipMapped = true, - .m_IsStorage = true}); + auto brdfLut = resourceManager->CombinedImageViews().CreateTexture2D({ + .m_Format = vk::Format::eR16G16Sfloat, + .m_Extent = {512, 512}, + .m_Name = "BRDF LUT", + .m_IsSampled = true, + .m_IsMipMapped = false, + .m_IsStorage = true, + }); auto brdfLutSampler = resourceManager->Samplers().CreateSampler({ .m_AddressModeU = vk::SamplerAddressMode::eClampToEdge, @@ -356,7 +358,6 @@ CreateCubeFromHdrEnv(AssetLoader *assetLoader, vk::Queue computeQueue, const u32 cmd.pipelineBarrier2(&skyboxToSampleDependency); cmd.pipelineBarrier2(&prefilterToSampleDependency); - TODO("BRDF LUT has a black line at x=0. Needs fixing"); cmd.bindPipeline(vk::PipelineBindPoint::eCompute, brdfLutPipeline); cmd.pushConstants(pipelineLayout, vk::ShaderStageFlagBits::eCompute, 0, sizeof brdfLutPushConstants, &brdfLutPushConstants);