From dfdbd520871f930a6727d4b7bae7a8b0104a96ba Mon Sep 17 00:00:00 2001
From: Anish Bhobe <anishbhobe@hotmail.com>
Date: Sun, 23 Feb 2025 00:06:08 +0100
Subject: [PATCH] Messaging fixes in image and O3 in Cmake.

---
 CMakeLists.txt                 | 1 +
 aster/src/aster/core/image.cpp | 6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index aeb8a3c..055d78d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -10,6 +10,7 @@ set(CMAKE_CXX_EXTENSIONS OFF)
 
 if (MSVC)
     set(CMAKE_CXX_FLAGS "/W4 /GR- ${MSVC_FLAGS}")
+    set(CMAKE_CXX_FLAGS_RELEASE "/O3")
     add_compile_definitions(_HAS_EXCEPTIONS=0)
     add_compile_definitions(_CRT_SECURE_NO_WARNINGS)
     add_compile_definitions(${MSVC_DEFINES})
diff --git a/aster/src/aster/core/image.cpp b/aster/src/aster/core/image.cpp
index 88fd737..df895d1 100644
--- a/aster/src/aster/core/image.cpp
+++ b/aster/src/aster/core/image.cpp
@@ -109,7 +109,7 @@ Remember, we use upside down viewport.
 void
 TextureCube::Init(const Device *device, u32 cubeSide, vk::Format imageFormat, bool isMipMapped, cstr name)
 {
-    WARN_IF(!IsPowerOfTwo(cubeSide), "Image {1} is {0}x{0} (Non Power of Two)", cubeSide, name ? name : "<unnamed>");
+    WARN_IF(!IsPowerOfTwo(cubeSide), "Image Cube {1} has side {0}x{0} (Non Power of Two)", cubeSide, name ? name : "<unnamed>");
 
     const u8 mipLevels = isMipMapped ? 1 + Cast<u8>(floor(log2(cubeSide))) : 1;
 
@@ -119,7 +119,7 @@ TextureCube::Init(const Device *device, u32 cubeSide, vk::Format imageFormat, bo
         usage |= vk::ImageUsageFlagBits::eTransferSrc;
     }
 
-    vk::Extent3D extent = {.width = cubeSide, .height = cubeSide, .depth = 1};
+    const vk::Extent3D extent = {.width = cubeSide, .height = cubeSide, .depth = 1};
 
     vk::ImageCreateInfo imageCreateInfo = {
         .flags = vk::ImageCreateFlagBits::eCubeCompatible,
@@ -216,7 +216,7 @@ AttachmentImage::Init(const Device *device, vk::Extent2D extent, vk::Format imag
             },
     };
     result = device->m_Device.createImageView(&imageViewCreateInfo, nullptr, &view);
-    ERROR_IF(Failed(result), "Could not create depth image view {}. Cause: {}", name, result) THEN_ABORT(result);
+    ERROR_IF(Failed(result), "Could not create attachment image view {}. Cause: {}", name, result) THEN_ABORT(result);
 
     m_Image = image;
     m_View = view;